This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Tests v2 recreate #760
Merged
Tests v2 recreate #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Geometrically
suggested changes
Nov 25, 2023
src/routes/v2/version_creation.rs
Outdated
Comment on lines
103
to
110
| // Handle project type via file extension prediction | ||
| let mut project_type = None; | ||
| for file_part in &legacy_create.file_parts { | ||
| if let Some(ext) = file_part.split('.').last() { | ||
| match ext { | ||
| "jar" => { | ||
| project_type = Some("mod"); | ||
| break; |
There was a problem hiding this comment.
see other pr, should probably port this over. we should only handle this for modpack .mrpack files
Geometrically
approved these changes
Nov 25, 2023
thesuzerain
added a commit
that referenced
this pull request
Dec 5, 2023
* added common project information; setup for v2 test change * all tests now use with_test_environment * progress, failing * finished re-adding tests * prepare * cargo sqlx prepare -- --tests * fmt; clippy; prepare * sqlx prepare * adds version_create fix and corresponding test * merge fixes; rev * fmt, clippy, prepare * test cargo sqlx prepare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds v2 testing- allows as many tests as possible to test in both V2 and V3 APIs. Any test that uses the test_environment_all function will perform the test with both APIs.
Diff # is misleading. This also makes tests more consistent across the board and using the same format: a closure that can be called multiple times for each API. Because so many lines were indented, the diff looks quite large. (maybe closer to 1k-2k lines in actuality, and most of that is repeated changes across many tests).
(The substantial reviewable parts are the ApiBuildable, Api, etc traits and that setup)