This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Side types overhaul #762
Merged
Side types overhaul #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesuzerain
force-pushed
the
side-types-overhaul
branch
from
d9481c0 to
3c74fa8
Compare
… side-types-overhaul
Geometrically
approved these changes
Nov 28, 2023
thesuzerain
added a commit
that referenced
this pull request
Dec 5, 2023
* side types overhaul * fixes, fmt clippy * migration fix for v3 bug * fixed migration issues * more tested migration changes * fmt, clippy * bump cicd --------- Co-authored-by: Geometrically <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This includes retroactive fixes for dynamic fields.sql
Make sure migrations are reapplie dand that database is back from then.
Updates side types to 4 boolean fields, adds tests, and modifies search to allow v2 to make it (basically, allows a third depth level of facets to allow the deepest level to be AND. Boolean math doesn't quite work in v2-v3 conversion of side types if the lowest level is OR).
Fixes MOD-151