Don't attempt to delete remote branch after a PR has landed. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub deletes the remote branch automatically when the PR is merged, so we don't to explicitly do that. Trying to delete it currently results in an error like this: ``` error: unable to delete 'ZolotukhinM/stack/1': remote ref does not exist error: failed to push some refs to '...' ``` The code for deleting the branch has been sitting there for a long time, but until a fix in #27 it used incorrect branch names. stack-info: PR: #42, branch: ZolotukhinM/stack/1
ZolotukhinM
force-pushed
the
ZolotukhinM/stack/1
branch
from
88cc3bd to
357b790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Don't attempt to delete remote branch after a PR has landed.
GitHub deletes the remote branch automatically when the PR is merged, so
we don't to explicitly do that. Trying to delete it currently results in
an error like this:
The code for deleting the branch has been sitting there for a long time,
but until a fix in #27 it used incorrect branch names.