Add mouse keys #23
Open
Add mouse keys #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
2 times, most recently
from
3ef0506 to
b050936
Compare
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
3 times, most recently
from
a164626 to
e87dc9f
Compare
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
from
e87dc9f to
893c4a0
Compare
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
from
893c4a0 to
1a700dd
Compare
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
from
1a700dd to
3111d42
Compare
|
Would be nice to have diagonal mouse movement keys as well as mouse warp keys like the Kaleidoscope firmware does as well. |
These are both planned, I believe, but this is just a backport from the ZMK PR to add mouse movement |
|
You can get diagonal movements by combining multiple movement parameters. e.g. to go up-right use |
|
With this patch, is there a way to have a modifier to increase mouse move speed? For example, my |
|
While there isn't a modification functionality to affect the speed or other properties of the keys while held, you can have separate keys to go separate speeds, e.g. You can even define new mouse move instances with different acceleration etc.: |
|
Separate keys with different move speeds worked, thanks. I would still use a modifier key if it was possible though. |
sergey-tihon
added a commit
to sergey-tihon/glove80-zmk-config
that referenced
this pull request
Feb 11, 2024
|
Would it be possible to rebase this on top of #27 so that we can have BLE fixes and mouse controls in the same firmware? |
Co-authored-by: Alexander Krikun <[email protected]> Co-authored-by: Robert U <[email protected]> Co-authored-by: Shawn Meier <[email protected]>
bryanforbes
force-pushed
the
mouse-3.2-moergo
branch
from
3111d42 to
bd7b361
Compare
|
I was able to build with this branch before the last commits, but now it's failing: https://github.com/osa1/glove80-zmk-config/actions/runs/7776017512/job/21774531277. I'm using the moergo-sc/globa80-zmk-config with the git repo and branch name updated to use this branch: https://github.com/osa1/glove80-zmk-config/blob/main/.github/workflows/build.yml. |
|
@osa1 Yes, I need to fix the build today. I took some commits from Pete's mouse branch that rely on a feature we don't have here. |
|
@bryanforbes thanks for fixing the build. Not sure if you're aware of the issue but with the current version (fbaeb90) mouse controls stopped working. My key map is here: https://github.com/osa1/glove80-zmk-config/blob/main/config/glove80.keymap. It works with the version currently on glove80.com layout editor. |
|
I have a different problem. When I'm compiling ( logs |
|
A small update. My compilation error was caused by this: |
|
The mystery is partially solved. The website uses one of the deleted commits. They all were overwritten by the force-pushed commits. Thankfully, there is a way to checkout an orphan commit from the GitHub. Here is an automation recipe for that: recipedefault:
read -r url; \
hash=$(basename "$url"); \
archive="$hash.zip"; \
rm -rf src && \
wget "https://github.com/moergo-sc/zmk/archive/$archive" && \
unzip "$archive" && \
rm "$archive" && \
mv "zmk-$hash" src && \
cd .. && just || true; \
echo "$hash"After that, I just run Now, I literally copied every single URL one by one from top to bottom and from left to right. Here are my notes: notesprelatest successful #2fad527c all:
not compilable: compilable: works:
doesn't work: notes (raw)All URLs are listed under "all:". The ones that did compile under "compilable:", the others — under "not compilable:". Among compilable there are the ones that do enable the feature from this PR ("works:"), and the others that did not ("doesn't work:"). There are 3 deleted and 3 on-branch commits that did not compile (6), 8 deleted and one (last) on-branch commit (9) that did compile. The same (last) on-branch commit and 3 deleted commits didn't enable the feature and mostly mouse keys worked as no-op (some/all keys from fbaeb90 worked as transparent keys). 5 deleted commits worked. One of them (1a700dd) requires a both-halves restart, because initially the right half doesn't work for some reason. Now for the sad result. Even though cursor movements and mouse keys did work for those 5 deleted commits, it only worked (as expected) when the keyboard was connected over the wire. When connected wirelessly (basically how it always connected), only the right cursor movement works as expected. "Move up" works as a hyper-sensitive "move left", "down" — as "right", "left" as — as "right". Basically the speed is as unusable as it can get and decreasing max speed didn't change a thing. And the scrolling keys don't work either, apparently. They weirdly move the cursor up and down but some constant (?) amount. The LMB, MMB, RMB keys do work in both modes. So for me the current 5 commits only allow for the 3 mouse buttons and very 99% unusable cursor movement (probably much easier and faster would be to still use touchpad for that). I haven't checked the diffs between these commits, so I don't know how easy it would be to re-enable the feature on at least one on-branch commit, and also have no idea why only right movement is correctly working wirelessly. But hopefully this mini-research will help move this PR further. BTW, same issue with the '.uf2' from the website. P.S. I forgot to re-attach the right half after trying out the first working commit, so after another flash I broke the syncing link. Thought that I have to manually but the RH into the bootloader mode, but soon realized that I can just roll back to the previous version on the LH. Had to use another keyboard for that. Then they successfully linked, and I was able to move through versions normally. Update № 1It was confirmed that the web Update № 2After doing some stuff the cursor manipulation keys started to work properly (wirelessly). It may be due to restarting of the machine or something unknown. In any case, I'm loving this feature so far. I physically removed my trusty touchpad away from the desk and now I only have the keyboard with me. I definitely use this feature everyday (in certain apps it's the only way) and it's pretty damn good. The only problem I faced is that the horizontal scrolling kicks in with a delay and/or its speed is very slow (can this be tweaked?), but also that the vertical scroll sometimes stops working for a moment. I don't think that happens with regular scroll. |
|
Any reason why this is not being merged? Would be nice to use the keyboard with the latest firmware and mouse as well! |
|
My guess is that it's incomplete. And that the last commit broke the feature. I don't think that reverting to previous commit is a great idea as some progress will probably be lost. So the first thing should be to fix the feature on this branch. You can already use this feature by using 3111d42 if you build yourself. Or use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the following: