Feature/add single comparison column validation check #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threshold Minor bug in filtering predict table
…in only one linkage column
|
Ah oops, I forgot to check if any of our tests are affected by this logic... |
|
@RobinL could you let me know if you even want this change in Splink3. I can port the code to v4 and ignore this version if preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Adds a validation check to assess whether any input data frames entered by a user have only a single comparison column - #1392.
Give a brief description for the solution you have provided
This function adds a basic check to determine whether any of the user's data frames contain only one comparison column after excluding the unique_id and source_dataset columns.
Where this is true, Splink will generate invalid SQL, leading to cryptic SQL errors that may be difficult to interpret.
NB: this check only activates if the user has correctly specified unique_id and source_dataset. Should there be any mistakes in entering these variables in the settings, other validation checks will identify and highlight these errors.
PR Checklist