Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for git diff issue in perltidy workflow and use updated perl images for all other tests #153

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

nicomen
Copy link
Collaborator

@nicomen nicomen commented Jun 19, 2024

Summary

  1. Setting the current dir as a safe directory in perltidy workflow to be able to run the git diff command without error: warning: Not a git repository. Use --no-index to compare two paths outside a working tree ext code

  2. Using Debian tagged perl docker images as the existing perl ones are failing due to using an older format

Motivation

  1. Apparently a security fix in Git made git commands fail, possibly due to different owner of parent directory.

  2. Current perl images yield the following error when pulled: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/perl:5.14 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/ Error: Docker pull failed with exit code 1

References

safe directory issue: actions/checkout#766
perl images issue: briandfoy/cpan-audit#58

@nicomen nicomen changed the title Add workaround for git diff issue in github actions Add workaround for git diff issue in perltidy workflow and use updated perl images for all other tests Jun 19, 2024
@kraih
Copy link
Member

kraih commented Jun 19, 2024

Please squash commits so we can merge.

Add workaround for git diff issue: actions/checkout#766

Fix indentation that perltidy complains about

Use Debian tagged images for the the perl images

Use newer checkout version to avoid node deprecation warnings
@kraih kraih merged commit 1aa3eef into main Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants