-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating About section #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Includes updates to home page and about/teams page --------- Co-authored-by: Vincent Rubinetti <[email protected]>
(dont worry i have vince's verbal approval) |
kevinschaper
pushed a commit
that referenced
this pull request
Aug 22, 2023
- [x] #210 - [x] #269 - [x] #259 - [x] Update teams.json - [x] Update teams UI - [x] #232 - [x] remove Mastodon link - Added an in-progress Phenomics First page - Added `scripts/get_publications.py`: - Uses `scholarly` to get publications from Google Scholar - Filters duplicates, known "bad" titles, and titles already in the existing `publications.json` - Outputs `new_pubs.json` to be manually curated and added to existing `publications.json` - Also gets citation counts (and updates the structure of `publications.json` to include) - Publications - Used script to update existing `publications.json` - Update `PagePublications.vue` to include metadata and graphic - Teams - Updated UI (thanks Vince!) - Some updates to members (still waiting on updated QMUL list) - Get remaining team member changes (still need updated list from QMUL I think) - ~~Fix frontend tests~~ --------- Co-authored-by: Vincent Rubinetti <[email protected]>
This was referenced Aug 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
scripts/get_publications.py
:scholarly
to get publications from Google Scholarpublications.json
new_pubs.json
to be manually curated and added to existingpublications.json
publications.json
to include)publications.json
PagePublications.vue
to include metadata and graphicTo Do
Fix frontend tests