Update the GARD subset in Mondo #6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matentzn Can you please confirm that all I am expecting is the update to the Mondo-edit file? Thanks. |
sabrinatoro
reviewed
Dec 8, 2023
There was a problem hiding this comment.
@matentzn The GARD cross-references are duplicated (one has a "in mondo-subsets"). I don't think it is expected. (see image)
Also, please confirm that these are only x-refs (and therefore doesn't need "Mondo: equivalentTo")
|
The gard_rare subset declaration is in duplicate on many if not all terms where it is added. |
|
|
|
I should have deleted the import.. Now I have to wait again for the QC to pass :D |
sabrinatoro
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
It looks good to me, @matentzn
I will merge once QC have passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GARD subset in Mondo. In particular it: