Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

197 move gene prioritisation specific methods in analysispy #198

Merged

Conversation

yaseminbridges
Copy link
Contributor

@yaseminbridges yaseminbridges commented Sep 14, 2023

Moved prioritisation type-specific methods/classes into their own files (Disease/Gene/Variant) as well as some other methods/classes into separated files to avoid cyclic imports. None of the actual methods/classes have changed, just moving around code

@yaseminbridges yaseminbridges linked an issue Sep 14, 2023 that may be closed by this pull request
@yaseminbridges yaseminbridges self-assigned this Sep 14, 2023
@yaseminbridges yaseminbridges marked this pull request as ready for review September 14, 2023 12:19
Copy link
Contributor

@julesjacobsen julesjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better having split these into more manageable sizes and focused functionalities.

@yaseminbridges
Copy link
Contributor Author

@matentzn did you want to look at this before I merge it in? It's just moving code around into separate files to make it more manageable for the future

Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yaseminbridges yaseminbridges merged commit a3ce4c8 into main Sep 21, 2023
@yaseminbridges yaseminbridges deleted the 197-move-gene-prioritisation-specific-methods-in-analysispy branch October 23, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move prioritisation-specific methods in analysis.py
3 participants