Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor docstrings in post_processing.py #212

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Refactor docstrings in post_processing.py #212

merged 3 commits into from
Dec 7, 2023

Conversation

yaseminbridges
Copy link
Contributor

Refactoring docstrings for classes and functions in post_processing.py to follow google docstring fornatting

@yaseminbridges yaseminbridges linked an issue Nov 21, 2023 that may be closed by this pull request
refactor doctorings in post_processing.py #211
Closed
@yaseminbridges yaseminbridges marked this pull request as ready for review November 21, 2023 15:38
@julesjacobsen
Copy link
Contributor

This looks great and it massively improves the codebase. However it also highlights some issues regarding identifiers for chromosomes, genes and diseases. Can you add explanations about these as they will presumably affect the results to greater or lesser degrees.

@yaseminbridges
Copy link
Contributor Author

yaseminbridges commented Dec 4, 2023 •
edited
Loading

This looks great and it massively improves the codebase. However it also highlights some issues regarding identifiers for chromosomes, genes and diseases. Can you add explanations about these as they will presumably affect the results to greater or lesser degrees.

@julesjacobsen I've specified the identifiers for chromosomes, genes and diseases and also added in the Notes that these can ultimately be what is found in the phenopacket as it is used for matching purposes in the analysis

@yaseminbridges yaseminbridges merged commit ee1c19f into main Dec 7, 2023
5 checks passed
@yaseminbridges yaseminbridges deleted the 211-refactor-doctorings-in-post_processingpy branch December 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souzadevinicius souzadevinicius Awaiting requested review from souzadevinicius

@julesjacobsen julesjacobsen Awaiting requested review from julesjacobsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor doctorings in post_processing.py
2 participants
@yaseminbridges @julesjacobsen