implement handling of empty results #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaseminbridges
requested review from
julesjacobsen,
souzadevinicius and
matentzn
matentzn
reviewed
Dec 7, 2023
| @@ -449,6 +449,9 @@ def generate_pheval_result( | |||
| Raises: | |||
| ValueError: If the results are not all the same type or an error occurs during file writing. | |||
| """ | |||
| if not pheval_result: | |||
| print(f"Warning: No results found for {tool_result_path.name}") | |||
There was a problem hiding this comment.
I dont know how far this goes but you should avoid at all time to use print() in favour of logging.warning or logging.info() so that the client can set their preferred reporting levels.
| @@ -450,7 +451,7 @@ def generate_pheval_result( | |||
| ValueError: If the results are not all the same type or an error occurs during file writing. | |||
| """ | |||
| if not pheval_result: | |||
| print(f"Warning: No results found for {tool_result_path.name}") | |||
| info_log.warning(f"No results found for {tool_result_path.name}") | |||
There was a problem hiding this comment.
Shouldn't this log an error, not a warning?
There was a problem hiding this comment.
I wasn’t sure. I can change it to log an error but I didn’t to begin with because sometimes the tool doesn’t generate results and there isn’t an error with the tool itself
souzadevinicius
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in the post-processing methods that will print a warning message if there are no results found. This should stop the error @souzadevinicius was getting in his experiments and write out the rest of the results without stopping the entire process.