Skip to content

Commit

Permalink
Change default value of DELEGATE_AUTHORIZED_ROLES
Browse files Browse the repository at this point in the history
Change default value of DELEGATE_AUTHORIZED_ROLES from `admin` to
`monitoring-delegate` because of following two reasons.
- There is inconsistency between monasca-docker default value and
OpenStack monasca api project document.
- It's not secure to allow admin authorization to other users.
  • Loading branch information
haruki-yamanashi committed Nov 28, 2017
1 parent 5bb5a37 commit be9d6d0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion monasca-api-python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ A number of environment variables can be passed to the container:
| `AUTHORIZED_ROLES` | `user, domainuser, domainadmin, monasca-user` | Roles for admin Users |
| `AGENT_AUTHORIZED_ROLES` | `monasca-agent` | Roles for metric write only users |
| `READ_ONLY_AUTHORIZED_ROLES` | `monasca-read-only-user` | Roles for read only users |
| `DELEGATE_AUTHORIZED_ROLES` | `admin` | Roles allow to read/write cross tenant ID |
| `DELEGATE_AUTHORIZED_ROLES` | `monitoring-delegate` | Roles allow to read/write cross tenant ID |
| `ADD_ACCESS_LOG` | `true` | if true, produce an access log on stderr |
| `ACCESS_LOG_FORMAT` | `%(asctime)s [%(process)d] gunicorn.access [%(levelname)s] %(message)s` | Log format for access log |
| `ACCESS_LOG_FIELDS` | `%(h)s %(l)s %(u)s %(t)s %(r)s %(s)s %(b)s "%(f)s" "%(a)s" %(L)s` | Access log fields |
Expand Down
2 changes: 1 addition & 1 deletion monasca-api-python/api-config.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ read_only_authorized_roles = {{ READ_ONLY_AUTHORIZED_ROLES | default('monasca-re

# The roles that are allowed to access the API on behalf of another tenant.
# For example, a service can POST metrics to another tenant if they are a member of the "delegate" role.
delegate_authorized_roles = {{ DELEGATE_AUTHORIZED_ROLES | default('admin') }}
delegate_authorized_roles = {{ DELEGATE_AUTHORIZED_ROLES | default('monitoring-delegate') }}

[messaging]
# The message queue driver to use
Expand Down

0 comments on commit be9d6d0

Please sign in to comment.