Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moneymeets/adjust for keycloak 22 #11

Merged
merged 12 commits into from
Apr 16, 2024

Conversation

windwinkel
Copy link

No description provided.

@marns93 marns93 force-pushed the moneymeets/adjust-for-keycloak-22 branch from 14acdfe to f6059ce Compare March 26, 2024 09:37
Copy link

@mm-matthias mm-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see everything makes sense, added some smaller remarks and one question about the email addresses.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build-local.sh Outdated Show resolved Hide resolved
@windwinkel windwinkel force-pushed the moneymeets/adjust-for-keycloak-22 branch from f6059ce to 42f4e05 Compare April 3, 2024 06:19
@windwinkel windwinkel requested a review from mm-matthias April 5, 2024 08:04
Copy link

@pchorus pchorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. One comment.
I did not test anything.

@windwinkel
Copy link
Author

/rebase

@windwinkel windwinkel merged commit 5274414 into moneymeets/22.0.4 Apr 16, 2024
2 checks passed
@windwinkel windwinkel deleted the moneymeets/adjust-for-keycloak-22 branch April 16, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants