Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: mark test as skippable if locale is not available #777

Closed
wants to merge 2 commits into from
Closed

tests: mark test as skippable if locale is not available #777

wants to merge 2 commits into from

Conversation

Chris53897
Copy link
Contributor

This tests fails for me locally, because i do not have the locale installed.
I have to run tests one by one instead of composer test
With this change it makes it easier to test local.

@frederikbosch
Copy link
Member

frederikbosch commented Jan 26, 2024

But, if in CI, the test must fail if the locale is not there. So this solution is a little too easy.

@Chris53897
Copy link
Contributor Author

ok, i will think about a more robust solution.

@Chris53897
Copy link
Contributor Author

Is it valid to change it to a more commonly used Locale?
I guess US is comma seperated and the sense of the test ist still correct.
Please check this.

@frederikbosch
Copy link
Member

I rather leave it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants