Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45921-export-query-prep #703

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

ajhuh-mdb
Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb commented Dec 10, 2024

DESCRIPTION

  • Swapped out procedure to use the .. procedure:: directive
    • Updated procedures to reflect current UI experience (was outdated)
    • New images for updated UI

Other bug updates:

  • Moved open-new-tab steps yaml file to shared includes directory.
  • Added Compass-only tags to Data Lake note on Query Plan page + compass isolated version note on Schema page

STAGING

JIRA

https://jira.mongodb.org/browse/DOCSP-45921

BUILD LOG

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit 89f5d7a
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/675a00aa69dc120008f0ddbf
😎 Deploy Preview https://deploy-preview-703--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdb-ashley mdb-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple comments for your consideration. Thanks, Ali.

@@ -0,0 +1,17 @@
title: Click the caret icon next to the database which contains the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Click the caret icon next to the database which contains the
title: Click the caret icon next to the database that contains the

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@@ -0,0 +1,17 @@
title: Click the caret icon next to the database which contains the
collection you wish to view.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
collection you wish to view.
collection you want to view.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

@ajhuh-mdb ajhuh-mdb merged commit a5d1105 into mongodb:master Dec 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants