DOCSP-44895 - Shorten TOC labels #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarahemlin
reviewed
Oct 31, 2024
source/index.txt
Outdated
| Security </security> | ||
| Specialized Data Formats </data-formats> | ||
| C++17 Polyfill </polyfill-selection> | ||
| Advanced Configuration and Installation </advanced-installation> |
There was a problem hiding this comment.
@mongoKart, for the TOC-only, the ampersand is approved per the Style Guide.
sarahemlin
reviewed
Oct 31, 2024
source/get-started.txt
Outdated
| /get-started/create-a-connection-string/ | ||
| /get-started/connect-to-mongodb/ | ||
| /get-started/next-steps/ | ||
| Download and Install </get-started/download-and-install/> |
There was a problem hiding this comment.
ampersand over here, too
lindseymoore
requested changes
Nov 1, 2024
Comment on lines
+26
to
+27
| Single Field Indexes </indexes/single-field-index> | ||
| Compound Indexes </indexes/compound-index> |
There was a problem hiding this comment.
Suggested change
| Single Field Indexes </indexes/single-field-index> | |
| Compound Indexes </indexes/compound-index> | |
| Single Field </indexes/single-field-index> | |
| Compound </indexes/compound-index> |
S: Since Indexes is already in title, and it is a bit repetitive. But also understand keeping it since Single Field Indexes is more of a MongoDB specific term. We'll discuss
There was a problem hiding this comment.
I agree that Indexes is probably needed here since it is not implied
lindseymoore
approved these changes
Nov 4, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v3.10 v3.10
# Navigate to the new working tree
cd .worktrees/backport-v3.10
# Create a new branch
git switch --create backport-68-to-v3.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6ae0203a61719478fe49a6ad7d52a5f981da68fc
# Push it to GitHub
git push --set-upstream origin backport-68-to-v3.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v3.10Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 6ae0203)
mongoKart
added a commit
that referenced
this pull request
Nov 4, 2024
(cherry picked from commit 6ae0203) Co-authored-by: Mike Woofter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44895
Self-Review Checklist