Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-45012) Transactions #71
(DOCSP-45012) Transactions #71
Changes from all commits
25b5bb8
a41f264
7c0b013
64cdb5c
1528874
9783144
fb50c58
97f573a
7fb6f64
5d151bc
ab493d6
93742f5
acf1eda
cec82eb
50213c0
e105e2e
490de3c
06ca58b
d18abff
fd6a0eb
d1c3d54
c317a97
790110f
665e5c0
2931dc7
1512764
7f33c54
17424ef
9754844
1c11e70
b668948
02d6011
7a3fc40
5492ba4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: link to https://www.mongodb.com/docs/manual/core/transactions/ like the Go page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I have generally been advised by Nora to avoid inline links where the link destination is not explicitly described in the text. So, being a little careful to follow the Link With Care section of the style guide, I'm avoiding inline links in the first few paragraphs and instead have an Additional Information section at the bottom of the page that has links to Transactions, causal consistency, etc.
If you still think this link would be helpful, let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: link to https://www.mongodb.com/docs/manual/core/read-isolation-consistency-recency/#causal-consistency for causal consistency since this can be an unfamiliar concept
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reply as above!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For causal consistency, I do think it can be an unfamiliar term so I think it would be good to provide some sort of reference when it's mentioned (doesn't have to be a link - could be a short definition). I don't feel too strongly about it though, so I defer to your judgement!
Check failure on line 50 in source/write/transactions.txt
GitHub Actions / TDBX Vale rules