-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45313: Remove mongocxx::stdx namespace #83
DOCSP-45313: Remove mongocxx::stdx namespace #83
Conversation
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ fixes
source/upgrade.txt
Outdated
@@ -159,6 +159,12 @@ The v4.0 driver introduces the following breaking changes to the API: | |||
library equivalents. For context, see the :ref:`Build System Breaking Changes | |||
<version-4.0-build-system-breaking>` section. | |||
|
|||
- Removes the the ``mongocxx::stdx`` namespace. Replace the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Removes the the ``mongocxx::stdx`` namespace. Replace the following | |
- Removes the ``mongocxx::stdx`` namespace. Replace the following |
source/upgrade.txt
Outdated
@@ -169,6 +175,12 @@ The v4.0 driver introduces the following breaking changes to the ABI: | |||
library equivalents. For context, see the :ref:`Build System Breaking Changes | |||
<version-4.0-build-system-breaking>` section. | |||
|
|||
- Removes the the ``mongocxx::stdx`` namespace. Replace the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Removes the the ``mongocxx::stdx`` namespace. Replace the following | |
- Removes the ``mongocxx::stdx`` namespace. Replace the following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to address; otherwise, LGTM.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45313
Staging - https://deploy-preview-83--docs-cpp.netlify.app/upgrade/#version-4.0
Self-Review Checklist