Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-45313: Remove mongocxx::stdx namespace #83

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Nov 22, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45313
Staging - https://deploy-preview-83--docs-cpp.netlify.app/upgrade/#version-4.0

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-cpp ready!

Name Link
🔨 Latest commit 716eed1
🔍 Latest deploy log https://app.netlify.com/sites/docs-cpp/deploys/6740d8137eb1130008f5e7d0
😎 Deploy Preview https://deploy-preview-83--docs-cpp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ fixes

@@ -159,6 +159,12 @@ The v4.0 driver introduces the following breaking changes to the API:
library equivalents. For context, see the :ref:`Build System Breaking Changes
<version-4.0-build-system-breaking>` section.

- Removes the the ``mongocxx::stdx`` namespace. Replace the following
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Removes the the ``mongocxx::stdx`` namespace. Replace the following
- Removes the ``mongocxx::stdx`` namespace. Replace the following

@@ -169,6 +175,12 @@ The v4.0 driver introduces the following breaking changes to the ABI:
library equivalents. For context, see the :ref:`Build System Breaking Changes
<version-4.0-build-system-breaking>` section.

- Removes the the ``mongocxx::stdx`` namespace. Replace the following
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Removes the the ``mongocxx::stdx`` namespace. Replace the following
- Removes the ``mongocxx::stdx`` namespace. Replace the following

@norareidy norareidy requested a review from eramongodb November 22, 2024 18:49
Copy link
Collaborator

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to address; otherwise, LGTM.

source/upgrade.txt Outdated Show resolved Hide resolved
@norareidy norareidy merged commit fe69195 into mongodb:master Nov 22, 2024
5 checks passed
@norareidy norareidy deleted the DOCSP-45313-mongocxx-namespace branch November 22, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants