DOCSP-45314: Removed headers #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
approved these changes
Nov 22, 2024
source/upgrade.txt
Outdated
| @@ -159,6 +159,13 @@ The v4.0 driver introduces the following breaking changes to the API: | |||
| library equivalents. For context, see the :ref:`Build System Breaking Changes | |||
| <version-4.0-build-system-breaking>` section. | |||
|
|
|||
| - Removes the following headers: | |||
There was a problem hiding this comment.
Q: would C++ devs be familiar with the term "headers" or do you think some more explanation could be useful here?
There was a problem hiding this comment.
I changed to "header files" to be more specific, but both headers/header files are mentioned throughout the docs
eramongodb
approved these changes
Nov 22, 2024
eramongodb
reviewed
Nov 22, 2024
source/upgrade.txt
Outdated
Comment on lines
207
to
213
| - Removes the following header files: | ||
|
|
||
| - ``<bsoncxx/stdx/make_unique.hpp>`` | ||
| - ``<bsoncxx/types/value.hpp>`` | ||
| - ``<bsoncxx/util/functor.hpp>`` | ||
| - ``<mongocxx/options/create_collection.hpp>`` | ||
|
|
There was a problem hiding this comment.
Suggested change
| - Removes the following header files: | |
| - ``<bsoncxx/stdx/make_unique.hpp>`` | |
| - ``<bsoncxx/types/value.hpp>`` | |
| - ``<bsoncxx/util/functor.hpp>`` | |
| - ``<mongocxx/options/create_collection.hpp>`` | |
This is not an ABI breaking change.
norareidy
added a commit
that referenced
this pull request
Nov 22, 2024
* DOCSP-45314: Removed headers * RR feedback * EC feedback (cherry picked from commit 2e96f85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45314
Staging - https://deploy-preview-84--docs-cpp.netlify.app/upgrade/#version-4.0
Self-Review Checklist