DOCSP-39791: Databases & collections #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mcmorisi
approved these changes
Dec 4, 2024
source/databases-collections.txt
Outdated
Comment on lines
50
to
51
| Alternatively, you can use the ``[]`` operator as a shorthand for the | ||
| ``database()`` function, as shown in the following code: |
There was a problem hiding this comment.
S: It might be helpful to specify that you need to use the [] operator on a mongocxx::client object.
source/databases-collections.txt
Outdated
Comment on lines
76
to
77
| Alternatively, you can use the ``[]`` operator as a shorthand for the | ||
| ``collection()`` function, as shown in the following code: |
There was a problem hiding this comment.
Same comment as above, but with a mongocxx::database object this time.
kevinAlbs
approved these changes
Dec 5, 2024
| mongocxx::read_preference rp; | ||
| rp.mode(mongocxx::read_preference::read_mode::k_secondary); | ||
| mongocxx::read_concern rc; | ||
| rc.acknowledge_level(mongocxx::read_concern::level::k_majority) |
There was a problem hiding this comment.
Suggested change
| rc.acknowledge_level(mongocxx::read_concern::level::k_majority) | |
| rc.acknowledge_level(mongocxx::read_concern::level::k_majority); |
| mongocxx::read_concern rc; | ||
| rc.acknowledge_level(mongocxx::read_concern::level::k_local) | ||
| mongocxx::write_concern wc; | ||
| wc.acknowledge_level(mongocxx::write_concern::level::k_acknowledged) |
There was a problem hiding this comment.
Suggested change
| wc.acknowledge_level(mongocxx::write_concern::level::k_acknowledged) | |
| wc.acknowledge_level(mongocxx::write_concern::level::k_acknowledged); |
| auto coll = client["test_database"]["test_collection"]; | ||
|
|
||
| mongocxx::read_concern rc; | ||
| rc.acknowledge_level(mongocxx::read_concern::level::k_local) |
There was a problem hiding this comment.
Suggested change
| rc.acknowledge_level(mongocxx::read_concern::level::k_local) | |
| rc.acknowledge_level(mongocxx::read_concern::level::k_local); |
norareidy
added a commit
that referenced
this pull request
Dec 6, 2024
* DOCSP-39791: Databases & collections * code edits * wording * MM feeback * KA feedback (cherry picked from commit 00f5a9a)
norareidy
added a commit
that referenced
this pull request
Dec 6, 2024
* DOCSP-39791: Databases & collections * code edits * wording * MM feeback * KA feedback (cherry picked from commit 00f5a9a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-39791
Staging - https://deploy-preview-87--docs-cpp.netlify.app/databases-collections/
Self-Review Checklist