Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade release signing to drivers-github-tools v2 #696

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented May 29, 2024

Description

upgrade to drivers-github-tools v2
note: this is lower priority compared to the other ssdlc PRs

What is changing?

  • upgrade to drivers-github-tools v2
  • skip adding signatures when release_notes does not finish running (fix)
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

v1 is no longer maintained.

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review May 31, 2024 20:15
package.json Outdated
@@ -14,7 +14,7 @@
"vendor"
],
"types": "bson.d.ts",
"version": "6.7.0",
"version": "3.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "3.7.0",
"version": "6.7.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, this was purely for testing, let me revert the git commits back.

@baileympearson baileympearson self-assigned this Jun 3, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 3, 2024
@baileympearson baileympearson changed the title refactor: upgrade release signing to drivers-github-tools v2 chore: upgrade release signing to drivers-github-tools v2 Jun 7, 2024
@baileympearson baileympearson merged commit 8cf9323 into main Jun 7, 2024
6 of 7 checks passed
@baileympearson baileympearson deleted the refactor-release-signing-v2 branch June 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants