-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade release signing to drivers-github-tools v2 #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditi-khare-mongoDB
temporarily deployed
to
release
May 29, 2024 19:55 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
temporarily deployed
to
release
May 29, 2024 19:57 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
had a problem deploying
to
release
May 29, 2024 20:13 — with
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
May 29, 2024 20:19 — with
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
May 29, 2024 20:26 — with
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
May 29, 2024 21:10 — with
GitHub Actions
Failure
aditi-khare-mongoDB
had a problem deploying
to
release
May 29, 2024 21:12 — with
GitHub Actions
Failure
aditi-khare-mongoDB
force-pushed
the
refactor-release-signing-v2
branch
from
May 29, 2024 21:23
94256c2
to
c8f5350
Compare
…odb/js-bson into refactor-release-signing-v2
aditi-khare-mongoDB
had a problem deploying
to
release
May 31, 2024 21:10 — with
GitHub Actions
Failure
aditi-khare-mongoDB
temporarily deployed
to
release
May 31, 2024 21:10 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
temporarily deployed
to
release
May 31, 2024 21:12 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
had a problem deploying
to
release
May 31, 2024 21:12 — with
GitHub Actions
Failure
aditi-khare-mongoDB
temporarily deployed
to
release
June 3, 2024 14:28 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
temporarily deployed
to
release
June 3, 2024 14:28 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
temporarily deployed
to
release
June 3, 2024 14:34 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
temporarily deployed
to
release
June 3, 2024 14:34 — with
GitHub Actions
Inactive
aditi-khare-mongoDB
force-pushed
the
refactor-release-signing-v2
branch
from
June 3, 2024 14:36
51d94f0
to
a185e6a
Compare
baileympearson
requested changes
Jun 3, 2024
package.json
Outdated
@@ -14,7 +14,7 @@ | |||
"vendor" | |||
], | |||
"types": "bson.d.ts", | |||
"version": "6.7.0", | |||
"version": "3.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"version": "3.7.0", | |
"version": "6.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, this was purely for testing, let me revert the git commits back.
baileympearson
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jun 3, 2024
baileympearson
approved these changes
Jun 7, 2024
baileympearson
changed the title
refactor: upgrade release signing to drivers-github-tools v2
chore: upgrade release signing to drivers-github-tools v2
Jun 7, 2024
baileympearson
pushed a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade to drivers-github-tools v2
note: this is lower priority compared to the other ssdlc PRs
What is changing?
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
v1 is no longer maintained.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript