Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update migration guide TLA #728

Merged
merged 2 commits into from
Nov 13, 2024
Merged

chore: update migration guide TLA #728

merged 2 commits into from
Nov 13, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Add note about TLA and bundling
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Clarity on the TLA and bundling subject

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from W-A-James November 13, 2024 16:12
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 13, 2024
docs/upgrade-to-v5.md Outdated Show resolved Hide resolved
docs/upgrade-to-v5.md Outdated Show resolved Hide resolved
Co-authored-by: Warren James <[email protected]>
@nbbeeken nbbeeken requested a review from W-A-James November 13, 2024 18:59
@W-A-James W-A-James merged commit 1508112 into main Nov 13, 2024
8 checks passed
@W-A-James W-A-James deleted the chore-update-guide-tla branch November 13, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants