-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6552): remove cache and use toStringTag in type helpers #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 61537f5.
addaleax
previously approved these changes
Nov 22, 2024
nbbeeken
changed the title
fix(NODE-6552): revert "Improve serialization performance"
fix(NODE-6552): remove cache and use toStringTag in type helpers
Nov 22, 2024
5 tasks
SeanReece
reviewed
Nov 26, 2024
SeanReece
reviewed
Nov 26, 2024
addaleax
reviewed
Nov 26, 2024
W-A-James
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Nov 26, 2024
W-A-James
previously approved these changes
Nov 26, 2024
W-A-James
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Nov 26, 2024
addaleax
previously approved these changes
Nov 26, 2024
nbbeeken
commented
Nov 26, 2024
W-A-James
approved these changes
Nov 27, 2024
durran
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 61537f5.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Release Highlight
Fix issue with the internal unbounded type cache
As an optimization, a previous performance improvement stored the type information of seen objects to avoid recalculating type information. This caused an issue in the driver under extreme load and high memory usage as the cache grew. The assumption was that garbage collection would clear it enough to sustain normal operation. The cache is now removed and other optimal type checking is used in its place.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript