Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSHARP-5203: Benchmark Collection and Client bulkWrite #1550

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CSHARP-5203: Benchmark Collection and Client bulkWrite #1550

wants to merge 7 commits into from

Conversation

adelinowona
Copy link
Contributor

@adelinowona adelinowona commented Nov 19, 2024 •
edited
Loading

Here are results of the new benchmarks:

Name MB/sec
SmallDocClientBulkWriteMixedOps 1.9320055323
SmallDocCollectionBulkWriteMixedOps 0.7543254574
LargeDocClientBulkWriteInsert 94.103463269
LargeDocCollectionBulkWriteInsert 96.6259091508
SmallDocClientBulkWriteInsert 36.7585335938
SmallDocCollectionBulkWriteInsert 40.8752903883


(Updated with latest EG run found here)

@adelinowona adelinowona requested a review from a team as a code owner November 19, 2024 16:59
@adelinowona adelinowona requested review from papafe, BorisDog and sanych-sun and removed request for a team November 19, 2024 16:59
BorisDog
BorisDog reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@BorisDog BorisDog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good overall, would be good to have a sample run attached.

CSharpDriver.sln Outdated Show resolved Hide resolved
@adelinowona adelinowona requested a review from BorisDog December 5, 2024 19:56
sanych-sun
sanych-sun approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BorisDog
BorisDog requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

benchmarks/MongoDB.Driver.Benchmarks/MultiDoc/BulkWriteMixedOpsBenchmark.cs Outdated Show resolved Hide resolved
benchmarks/MongoDB.Driver.Benchmarks/MultiDoc/BulkWriteMixedOpsBenchmark.cs Outdated Show resolved Hide resolved
evergreen/evergreen.yml Outdated Show resolved Hide resolved
@adelinowona adelinowona requested a review from BorisDog December 21, 2024 02:37
BorisDog
BorisDog approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

benchmarks/MongoDB.Driver.Benchmarks/MultiDoc/BulkWriteMixedOpsBenchmark.cs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanych-sun sanych-sun sanych-sun approved these changes

@BorisDog BorisDog BorisDog approved these changes

@papafe papafe Awaiting requested review from papafe papafe is a code owner automatically assigned from mongodb/dbx-csharp-dotnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelinowona @BorisDog @sanych-sun