-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSHARP-5423: Remove deprecated field from GridFS unified tests #1579
base: main
Are you sure you want to change the base?
Conversation
Not sure if we want to keep them, but for now I've moved the legacy tests inside the "legacy" folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the commit tree linear before we review.
@rstam Rebased on main |
Converted it to draft as I need to finish a couple of things |
@BorisDog regarding the deprecated fields, namely "contentType" and "aliases", I've removed them from the registered members of the serializers and also from a test method input given they were not used. mongo-csharp-driver/tests/MongoDB.Driver.Tests/GridFS/GridFSFileInfoTests.cs Lines 72 to 95 in 476af2b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
There was some confusion with the legacy tests, as I thought the spec contains both legacy
and unified
folders.
We need to align with the spec tests structure, and have just unified tests (and remove legacy runners).
So we need to do CSHARP-3587 as prerequisite. We could also address CSHARP-3587 as part of this ticket.
@@ -0,0 +1,97 @@ | |||
/* Copyright 2020-present MongoDB Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright 2010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected. I noticed that there are other files with various years, mostly in the test project.
@BorisDog, I've removed the legacy tests and their runners, so I suppose CSHARP-3587 could also be closed when this is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.