-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4079 Generate ManyLinux2014 and ManyLinux1 Wheels #1454
Conversation
The docs failure is unrelated, due to a DNS outage. |
In EVG we also build the manylinux1 wheels, can we add those as well? If manylinux1 wheels are no longer needed then could you update the changelog to mention we stopped releasing them? |
I'd prefer that route since we don't support Python 3.6 anymore, should I also remove them from the EVG script? |
Sounds good to me. This comment from Oct 2021 shows 3.7 has 8% manylinux1 usage and 2% manylinux2010 usage so it seems fine to drop them now: pypa/manylinux#994 (comment) |
doc/changelog.rst
Outdated
@@ -1,6 +1,12 @@ | |||
Changelog | |||
========= | |||
|
|||
Changes in Version 4.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next version is 4.7 which already has an entry below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, fixed.
Should we rename the PR to "Remove manylinux1 wheels"? |
.evergreen/build-manylinux.sh
Outdated
images=(quay.io/pypa/manylinux1_x86_64:2021-05-05-b64d921 \ | ||
quay.io/pypa/manylinux1_i686:2021-05-05-b64d921 \ | ||
quay.io/pypa/manylinux2014_x86_64:2021-05-05-1ac6ef3 \ | ||
images=(quay.io/pypa/manylinux2014_x86_64:2021-05-05-1ac6ef3 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the removal of i686 unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, manylinux1 wheels are Centos5. Is that what we were using before, and this upgrades to Centos7? We can't move to manylinux_x_y because it requires the new pip solver. Please respond if I've gotten any of this wrong.
I think I understand what's going on and why. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both x86 and i686 were manylinux1, but we're going to try and bring both back. Yes, this is related so supporting older versions of pip that come preinstalled on stock Centos 7. See the compat table here: https://github.com/pypa/manylinux. If we bump to manylinux2014, then we'd still support CentOS 7 rh-python38, but not stock CentOS 7.
I guess I also have one question: why not just keep manylinux1 until it becomes a maintenance burden? It seems like it doesn't cost us anything to keep building and publishing them. And it would benefit users on older distros. |
Looks like that can work:
|
@blink1073 All looks good. Two questions.
|
It means the symbols used support both of those manylinux targets.
Yes, apple silicon is not yet available on GitHub Actions |
No description provided.