Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: INTMDB-1163 Changed create only properties #768

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

Adelmar92
Copy link
Contributor

Proposed changes

Problem

in this issue #745 the user is trying to update the Mappings property.

Reading the SearchIndex documentation i see that Mappings is marked as Update requires: No interruption
image

this means that if the user modifies this property, cloud formation should only execute the update, but reading the cloud formation template the Mapping property is marked as CreateOnly, (CreateOnly properties remplaces the resource when updated)

so when the user is trying to update this property, the resource gets replaced even tho the docs show otherwise.

Solution

This got solved by removing the properties that are not read only.

image

Jira ticket: INTMDB-1163

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@Adelmar92 Adelmar92 self-assigned this Oct 9, 2023
@Adelmar92 Adelmar92 requested a review from a team as a code owner October 9, 2023 16:19
@Adelmar92 Adelmar92 changed the title bug: INTMDB-1163 Changed create only properties fix: INTMDB-1163 Changed create only properties Oct 9, 2023
@Adelmar92 Adelmar92 added this pull request to the merge queue Oct 9, 2023
Merged via the queue into master with commit e566987 Oct 9, 2023
24 of 25 checks passed
@Adelmar92 Adelmar92 deleted the feature/INTMDB-1163-fixed-readonly-properties branch October 9, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants