DOP-5238 Clone docs-laravel submodule for Netlify deploys #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for site-links-display failed. Why did it fail? →
|
❌ Deploy Preview for test-monorepo-redoc failed. Why did it fail? →
|
✅ Deploy Preview for slack-deploy-extension canceled.
|
✅ Deploy Preview for git-changed-file-extension canceled.
|
❌ Deploy Preview for search-manifest-extension failed. Why did it fail? →
|
✅ Deploy Preview for snooty-cache-extension canceled.
|
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for redirects-and-publish-extension canceled.
|
✅ Deploy Preview for populate-data-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for redoc-ext-test canceled.
|
❌ Deploy Preview for search-manifest-integration failed. Why did it fail? →
|
anabellabuckvar
changed the title
i80and
reviewed
Dec 17, 2024
|
|
||
| // Docs-laravel requires a submodule to build | ||
| if (repoName === 'docs-laravel') { | ||
| process.chdir(`${repoName}`); |
There was a problem hiding this comment.
It's typically better to pass in the cwd that you want into run.command, e.g. I think this is right: process.run(..., {cwd: reponame}).
process.chdir() will probably work for this purpose, but is an antipattern especially in async or threaded code because it's global process-wide state. While each task is running, and if any of these invocations throw, the process is in a bit of a weird liminal state.
There was a problem hiding this comment.
Thanks for pointing that out and explaining! Implemented changes accordingly
i80and
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET
DOP-5238 Clone docs-laravel submodule for Netlify deploys
NOTES
The docs-laravel repo has a submodule that is necessary for it to build properly. The repo already has a special build script for the docs-laravel Netlify site. This PR updates the laravel submodule and therefore enables docs-laravel to build on frontend-sourced Netlify sites(docs-frontend-stg, docs-frontend-dotcomstg, docs-frontend-dotcomprd)
The submodule is cloned in the same way as in this build script: https://github.com/10gen/docs-laravel/blob/v4.x/build.sh
STAGING LINKS
docs-frontend-dotcomstg laravel permalink. Deployed with netlify-test-deploy on Slack
docs-frontend-stg laravel permalink Deployed manually on netlify-testing-2 Snooty frontend branch