DOP-5196: save images to directory and update img src #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for search-manifest-integration failed. Why did it fail? →
|
✅ Deploy Preview for slack-deploy-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for git-changed-file-extension canceled.
|
✅ Deploy Preview for snooty-cache-extension canceled.
|
❌ Deploy Preview for site-links-display failed. Why did it fail? →
|
👷 Deploy Preview for site-links-display processing.
|
❌ Deploy Preview for test-monorepo-redoc failed. Why did it fail? →
|
❌ Deploy Preview for redirects-and-publish-extension failed. Why did it fail? →
|
✅ Deploy Preview for redoc-ext-test canceled.
|
❌ Deploy Preview for search-manifest-extension failed. Why did it fail? →
|
✅ Deploy Preview for populate-data-extension canceled.
|
✅ Deploy Preview for offline-snooty ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOP-5196
This PR updates the offline snooty extension to make images available in offline mode.![]()
DOM nodes with remote sources. If it finds any, it will download the image and save to the public/images directory to make it local, and update the src to the saved file.
While going through each HTML file, it looks for
Test build log here.
Sample HTML in S3 found here - download the zip, and open a page with remote images and inspect that it is pointing to the local image with a successful render