refactor(NODE-4144): remove all symbol properties #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
changed the title
nbbeeken
commented
Dec 11, 2024
baileympearson
added
the
Primary Review
baileympearson
requested changes
Dec 11, 2024
baileympearson
requested changes
Dec 11, 2024
baileympearson
previously approved these changes
Dec 11, 2024
baileympearson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to: #4133
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Symbol class properties were introduced to the driver before we adopted typescript and API-extractor to clearly indicate the accessibility of driver APIs. The symbol properties provided implied privacy, making properties non-trivial to access. Today we have the power of typescript private/protected and API-extractor's type deletion feature for APIs marked internal. With these tools, we can remove symbol properties in favor of appropriately marked string properties. This makes debugging internals easier by making inspection and assertion far more simple.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript