Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6622): pin npm version for node 18 to 10 #4358

Merged
merged 2 commits into from
Dec 17, 2024
Merged

chore(NODE-6622): pin npm version for node 18 to 10 #4358

merged 2 commits into from
Dec 17, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Add pins for npm 10 whereever we use node 18
Is there new documentation needed for these changes?

No

What is the motivation for this change?

NPM 11 drops support for node 18

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review December 17, 2024 21:56
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Dec 17, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Dec 17, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit e972bb8 into main Dec 17, 2024
28 of 31 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6622-pin-npm branch December 17, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi-khare-mongoDB aditi-khare-mongoDB aditi-khare-mongoDB approved these changes

Assignees

@aditi-khare-mongoDB aditi-khare-mongoDB

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @aditi-khare-mongoDB