Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove usage of fixed 2024-08-05 version in cluster resource and ensure auto scaling mode is not impacted #2918

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Dec 20, 2024

Description

Link to any related issue(s): CLOUDP-291400

When cluster resource requires using latest API is was fixed to 2024-08-05 version out of caution before doing ISS autoscaling epic. With proper testing now in place, we can safely use latest version instead of 2024-08-05 for specific PATCH requests that are made.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Dec 20, 2024
Comment on lines +1403 to +1404
nil, map[string]string{"redact_client_log_data": "true"},
acc.CheckIndependentShardScalingMode(resourceName, clusterName, "CLUSTER")), // latest PATCH API is called, ensure autoscaling mode is not modified
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure that even if redact_client_log_data is enabled (calling PATCH 2024-10-23) autoscaling mode is not impacted (because request does not include replicationSpecs/autoScaling properties)

@AgustinBettati
Copy link
Member Author

failing test is unrelated to changes, syncing with Aastha for fixing that test

@AgustinBettati AgustinBettati marked this pull request as ready for review December 20, 2024 14:06
@AgustinBettati AgustinBettati requested a review from a team as a code owner December 20, 2024 14:06
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants