-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove usage of fixed 2024-08-05 version in cluster resource and ensure auto scaling mode is not impacted #2918
base: master
Are you sure you want to change the base?
Conversation
…nd ensure auto scaling mode is not impacted
nil, map[string]string{"redact_client_log_data": "true"}, | ||
acc.CheckIndependentShardScalingMode(resourceName, clusterName, "CLUSTER")), // latest PATCH API is called, ensure autoscaling mode is not modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure that even if redact_client_log_data is enabled (calling PATCH 2024-10-23) autoscaling mode is not impacted (because request does not include replicationSpecs/autoScaling properties)
failing test is unrelated to changes, syncing with Aastha for fixing that test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
Description
Link to any related issue(s): CLOUDP-291400
When cluster resource requires using latest API is was fixed to 2024-08-05 version out of caution before doing ISS autoscaling epic. With proper testing now in place, we can safely use latest version instead of 2024-08-05 for specific PATCH requests that are made.
Type of change:
Required Checklist:
Further comments