fix: Avoids import error for database_user when both username and auth database contain hyphens #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APIx bot: a message has been sent to Docs Slack channel |
Comment on lines
+13
to
+20
| func ImportSplit3(importRaw string) (ok bool, part1, part2, part3 string) { | ||
| parts := strings.Split(importRaw, "/") | ||
| if len(parts) != 3 { | ||
| return false, "", "", "" | ||
| } | ||
| return true, parts[0], parts[1], parts[2] | ||
| } | ||
|
|
There was a problem hiding this comment.
[Curious] Is the use of / as a separator for import applied to all the resources? Besides this question, I think you should add additional documentation to highlight this change in the TF doc
There was a problem hiding this comment.
+1 would update the resource documentation import section.
maastha
reviewed
Dec 27, 2024
| @@ -364,3 +365,69 @@ func getDatabaseUserModel(roles, labels, scopes basetypes.SetValue, password typ | |||
| Scopes: scopes, | |||
| } | |||
| } | |||
|
|
|||
| func TestSplitDatabaseUserImportID(t *testing.T) { | |||
| const invalidDefaultString = "import format error: to import a Database User, use the format {project_id}-{username}-{auth_database_name} OR {project_id}/{username}/{auth_database_name}" | |||
There was a problem hiding this comment.
can we export this error message to a common const and re-use here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
idby/. See details on why/in issueLink to any related issue(s): CLOUDP-289266 #2876
Type of change:
Required Checklist:
Further comments