-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support for future_inbound
and future_outbound
in mongodbatlas_project_ip_addresses
data source
#2934
Conversation
Acceptance Tests: |
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"future_inbound": schema.ListAttribute{ | ||
ElementType: types.StringType, | ||
Computed: true, | ||
MarkdownDescription: "List of future inbound IP addresses associated with the cluster. If your network allows outbound HTTP requests only to specific IP addresses, you must allow access to the following IP addresses so that your application can connect to your Atlas cluster.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clarify these fields are temporal and only relevant for AWS clusters? Worth mentioning in the changelog entry as well so there is less friction when they are eventually removed.
If you agree we could also gives the feedback to the upstream team to mention in the API docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did share this concern with upstream (see ticket). Happy to sync more on this offline.
Description
Adds support for
future_inbound
andfuture_outbound
inmongodbatlas_project_ip_addresses
data sourceLink to any related issue(s): CLOUDP-279222
Type of change:
Required Checklist:
Further comments
Config:
TF console output: