Add forwardable module and upgrade rubocop #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like legit spec failures on mongoid 7? |
|
only for |
|
I can confirm the fix. Please also push to rubygems after release. Thanks guys! |
dks17
force-pushed
the
add-forwardable
branch
7 times, most recently
from
2711e2a to
eb8fb96
Compare
|
Cruikshanks
added a commit
to DEFRA/waste-carriers-engine
that referenced
this pull request
Jun 18, 2020
The front-office and back-office apps when the engine has been bumped have also taken on the latest version of mongoid-locker (v2.0.1) because it was not pinned. Though only a minor change it appears it has a dependency on Mongoid v7 and changes it has made around not using ActiveSupport method `delegate` since version 7.1 We ascertained this from a statement made in the issue [mongoid 7.1.0 issue with arguments](mongoid/mongoid-locker#85 (comment)) > Mongoid gem doesn't use ActiveSupport method delegate since 7.1 version. The issue was fixed in the mongoid-locker PR [Add forwardable module and upgrade rubocop](mongoid/mongoid-locker#86). And that change seems to be the key difference between version 2.0.0 and 2.0.1. The error we see in the apps when v2.0.1 is being used is ``` An error occurred while loading ./spec/forms/waste_carriers_engine/base_forms_spec.rb. Failure/Error: delegate :contact_address, :contact_email, :registered_address, to: :registration ArgumentError: wrong number of arguments (given 4, expected 1) ``` In this example if you go to order_copy_cards_registration.rb:10 you'll find ```ruby delegate :contact_address, :contact_email, :registered_address, to: :registration ``` Depending on whether you run rspec or try to hit a page in the app this is the error that gets thrown. So we are pinning the version of mongoid-locker we use, until we can complete the work to upgrade the version of ruby and rails we are using. We should then be able to use Mongoid v7.1 (or greater) and hopefully the issue goes away!
Cruikshanks
added a commit
to DEFRA/waste-carriers-engine
that referenced
this pull request
Jun 18, 2020
* Bump mongoid-locker from 2.0.0 to 2.0.1 Bumps [mongoid-locker](https://github.com/mongoid/mongoid-locker) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/mongoid/mongoid-locker/releases) - [Changelog](https://github.com/mongoid/mongoid-locker/blob/master/CHANGELOG.md) - [Commits](mongoid/mongoid-locker@v2.0.0...v2.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]> * Pin mongoid-locker to 2.0.0 The front-office and back-office apps when the engine has been bumped have also taken on the latest version of mongoid-locker (v2.0.1) because it was not pinned. Though only a minor change it appears it has a dependency on Mongoid v7 and changes it has made around not using ActiveSupport method `delegate` since version 7.1 We ascertained this from a statement made in the issue [mongoid 7.1.0 issue with arguments](mongoid/mongoid-locker#85 (comment)) > Mongoid gem doesn't use ActiveSupport method delegate since 7.1 version. The issue was fixed in the mongoid-locker PR [Add forwardable module and upgrade rubocop](mongoid/mongoid-locker#86). And that change seems to be the key difference between version 2.0.0 and 2.0.1. The error we see in the apps when v2.0.1 is being used is ``` An error occurred while loading ./spec/forms/waste_carriers_engine/base_forms_spec.rb. Failure/Error: delegate :contact_address, :contact_email, :registered_address, to: :registration ArgumentError: wrong number of arguments (given 4, expected 1) ``` In this example if you go to order_copy_cards_registration.rb:10 you'll find ```ruby delegate :contact_address, :contact_email, :registered_address, to: :registration ``` Depending on whether you run rspec or try to hit a page in the app this is the error that gets thrown. So we are pinning the version of mongoid-locker we use, until we can complete the work to upgrade the version of ruby and rails we are using. We should then be able to use Mongoid v7.1 (or greater) and hopefully the issue goes away! Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Alan Cruikshanks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #85