protect against decimals in menu/tape.lua #1804
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://llllllll.co/t/tape-isnt-recording/64461/10
re:
norns/lua/core/menu/tape.lua
Lines 56 to 61 in e8e210a
if a file in
audio/tape
is named something like10.20.24.wav
, then it'll bestring.sub
'd as index10.2
which passes thetonumber
check and gets assumed asm.fileindex
. but, later on, thisstring.format
fails, since10.2
doesn't have an integer representation and then the entire TAPE record process fails to initiate.a more robust fix would add
tapeindex
to thenorns.state
table for iteration, removing the need for this checking, but this modulo check seems like the least invasive option. happy to spin up in the other direction, though!