Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Documentation for MDL-81821 #1171

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[docs] Documentation for MDL-81821 #1171

merged 1 commit into from
Dec 17, 2024

Conversation

roland04
Copy link
Collaborator

@roland04 roland04 added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Oct 31, 2024
@roland04 roland04 self-assigned this Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8fcc91e
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/67619a9befeab90008d741ea
😎 Deploy Preview https://deploy-preview-1171--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 54 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🔴 39 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 59 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 56 🟢 95 🟢 100 🟢 100 🟢 100 Report

@andrewnicols
Copy link
Member

Pinging @ferranrecio to review this PR.

@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Dec 17, 2024
@ferranrecio
Copy link
Collaborator

ferranrecio commented Dec 17, 2024 •
edited
Loading

Hi @roland04 ,

Sorry for the delay. I missed the ping notification. Could you rebase your code?

@roland04 roland04 force-pushed the devdocs-bootstrap-font branch from 06bbef1 to 8fcc91e Compare December 17, 2024 15:36
@roland04
Copy link
Collaborator Author

roland04 commented Dec 17, 2024 •
edited
Loading

Thanks @ferranrecio! Rebased 👍

@ferranrecio
Copy link
Collaborator

Thanks for the rebase. Ready to merge.

ferranrecio
ferranrecio approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ferranrecio ferranrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch tested and reviewed. Ready to merge.

@ferranrecio ferranrecio added this pull request to the merge queue Dec 17, 2024
Merged via the queue into moodle:main with commit 984da11 Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferranrecio ferranrecio ferranrecio approved these changes

Assignees

@roland04 roland04

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roland04 @andrewnicols @ferranrecio @sarjona