Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the uuid extension. Some tests use it - 7.1-buster #95

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Add the uuid extension. Some tests use it - 7.1-buster #95

merged 1 commit into from
Oct 9, 2019

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Oct 9, 2019

(will help completing moodlehq/moodle-docker#110)

@stronk7 stronk7 changed the title Add the uuid extension. Some tests use it. Add the uuid extension. Some tests use it - 7.1-buster Oct 9, 2019
@stronk7 stronk7 merged commit c064cb2 into moodlehq:7.1-buster Oct 9, 2019
@stronk7
Copy link
Member Author

stronk7 commented Oct 9, 2019

moodlehq/moodle-ci-runner#15

@scara
Copy link
Contributor

scara commented Oct 9, 2019

Hi @stronk7,
a quick note: if you enable the extension, which is optional in a Moodle setup, we'll not skip its test but we would run it ever while it would be nice to test the code w/o that ext i.e. not enabled and than when enabled just to cover the skipped test.

At the time of moodlehq/moodle-docker#110 (comment) I was thinking how to enable it for just a run.

HTH,
Matteo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stronk7 @scara