Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-pytrakt] fix season number in show_collection #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonc56
Copy link
Contributor

In Users, the show_collection() function fetches all collected seasons as seasons 1.

Here :

PyTrakt/trakt/users.py

Lines 375 to 376 in 8a6d4f1

sh._seasons = [TVSeason(show=sh.title, **sea)
for sea in show.pop('seasons')]

Same as:

And the fix was:

fixes #76

@simonc56 simonc56 force-pushed the fix-tvseason-number branch from 6402630 to 80fae41 Compare June 13, 2022 21:06
@glensc
Copy link
Contributor

glensc commented Nov 2, 2022

@twolaw this is still valid to carry to python-pytrakt?

@simonc56
Copy link
Contributor Author

simonc56 commented Nov 6, 2022

yes

glensc added a commit to glensc/python-pytrakt that referenced this pull request Nov 6, 2022
@glensc
Copy link
Contributor

glensc commented Nov 6, 2022

Carried to my fork:

@twolaw can you please update pr title with [python-pytrakt] prefix to indicate so

@glensc glensc mentioned this pull request Nov 6, 2022
@simonc56 simonc56 changed the title fix season number in show_collection [python-pytrakt] fix season number in show_collection Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong TVSeason
2 participants