Remove unused ifndefs for GL_MULTISAMPLE #1609
Annotations
4 errors and 33 warnings
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax)
Process completed with exit code 1.
|
|
Cpplint
Process completed with exit code 1.
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L63
'Quarter/devices/Mouse.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy
Process completed with exit code 1.
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L366
connect(this, SIGNAL(sceneRectChanged(const QRectF&)), <--Consider using Functor-Based Connections
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L367
this, SLOT(onSceneRectChanged(const QRectF&))); <--Consider using Functor-Based Connections
|
|
Check old Qt string-based connections (https://wiki.qt.io/New_Signal_Slot_Syntax):
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L586
QTimer::singleShot(20, this, SLOT(update())); <--Consider using Functor-Based Connections
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L67
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L496
Using C-style cast. Use reinterpret_cast<SoCamera *>(...) instead [readability/casting] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L684
Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L692
Do not include .cpp files from other packages [build/include] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L201
Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L656
Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/Overlay.cpp#L45
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
Cpplint:
src/Mod/Sandbox/Gui/Overlay.cpp#L57
Single-parameter constructors should be marked explicit. [runtime/explicit] [4]
|
|
Cpplint:
src/Mod/Sandbox/Gui/Overlay.cpp#L244
Using C-style cast. Use reinterpret_cast<QMouseEvent *>(...) instead [readability/casting] [4]
|
|
Clazy
fatal error: 'Quarter/devices/Mouse.h' file not found
|
|
Clazy:
src/Mod/Sandbox/Gui/Overlay.h#L42
'SandboxGui::DrawingPlane::terminate' hides overloaded virtual function [-Woverloaded-virtual]
|
|
Clazy
note: hidden overloaded virtual function 'Gui::AbstractMouseSelection::terminate' declared here: different number of parameters (1 vs 0)
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L71
use '= default' to define a trivial default constructor [modernize-use-equals-default]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L75
use '= default' to define a trivial destructor [modernize-use-equals-default]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L84
do not use 'else' after 'return' [readability-else-after-return]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L89
use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L104
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L113
constructor does not initialize these fields: scene [cppcoreguidelines-pro-type-member-init]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L123
narrowing conversion from 'int' to signed type 'short' is implementation-defined [bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L124
narrowing conversion from 'int' to signed type 'short' is implementation-defined [bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L136
narrowing conversion from 'int' to signed type 'short' is implementation-defined [bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions]
|
|
Clang-tidy:
src/Mod/Sandbox/Gui/GLGraphicsView.cpp#L136
narrowing conversion from 'int' to signed type 'short' is implementation-defined [bugprone-narrowing-conversions,cppcoreguidelines-narrowing-conversions]
|
Loading