move build config to pyproject.toml #1015
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to recreate this to take into account the intended behaviors of LIMITED_DEPENDENCIES |
jdw25
added this to the Summer of Infrastructure (Non-Breaking Ifrastructure Improvements) milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new standard and it allows a lot of config to be done in this file, including configuration of dev tools like what I have suggested in #1013.
Doing this should also resolve the need for the LIMITED_DEPENDENCIES environment variable.
All packages have been grouped with an alias 'all' that installs everything but the dev requirements and tmc specific-packages.
I'm not sure about the Docker stuff though so I just made my best guess as to how to handle that.
It's also worth noting that LIMITED_DEPENDENCIES seems to have been implemented in such a way that most packages are not limited to a certain version, which means that you could end up with potentially quite different program behavior between LIMITED_DEPENDENCIES and normal install modes. This PR resolves this potential issue as all packages are declared per-module/in a single place.