Strive Connector Class

[thebbennett]

Overview

Strive is a popular broadcast SMS tool. The API developer docs can be found here. This PR represents the work to add a new connector class to Parsons.

To Do

• Determine why we can't pass params/horizontal filtering on get methjods
• Finish all GET requests
• Add unit tests for all get request methods
• Create documentation for new class

[SorenSpicknall]

Hey @thebbennett, did anybody ever connect with you about resolving the test issues that arose on this PR? Let me know if you need any advice to move forward with changes that'll get the PR into a passing state.

[thebbennett]

Hey! Very sorry about this- I started to build the Strive class and then got swept away by midterms. I opened the PR bc I like to work with an open PR. I tend to use a PR to take notes, make a checklist, document open Qs for myself, etc. Very sorry for any confusion this may have caused. If you need me to take down the PR, I can

I also very much intend to be more active in Parsons once I survive this last GA Runoff sprint

[thebbennett]

I'm back from the dead and have a renewed interested in working on this connector.

[thebbennett]

@shaunagm I can run my tests locally just fine because I've stored my Strive API key as a env param, but how can I get my Strive tests to run in CircleCI which is currently failing bc there is not Strive API key in the env

[shaunagm]

@thebbennett is there a way to set up a Strive sandbox that remains available indefinitely? If so, we can use the keys to the sandbox in the CI tests, and I can set that up (or we can pair on it, if you want to see how it works). Some platforms don't have sandboxes, though, in which case we use the @mark_live_test decorator to indicate it should not be run during CI.

[sharinetmc]

Hi @shaunagm! Stupid question, but I'm just wondering if the sandbox would need to be filled with data that must be public? Just thinking if I can make a sandbox on my end to help move this process along.

[shaunagm]

Not a dumb question, @sharinetmc! At least some of the data would be publicly exposed through the test suite, so we'd want to use fake data.

[sharinetmc]

Just changing the status to request changes. I also just contacted Strive about creating a sandbox for tests!

[thebbennett]

I'm no where near done with this PR! Still working on it

…

On Thu, Jun 22, 2023 at 3:56 PM sharinetmc ***@***.***> wrote: ***@***.**** requested changes on this pull request. Just changing the status to request changes. I also just contacted Strive about creating a sandbox for tests! — Reply to this email directly, view it on GitHub <#757 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG24UT5ZEGDPDFDWBWT2NDLXMSPQRANCNFSM6AAAAAARCQUOVY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *brittany bennett, she/her* *Analytics Engineer * https://www.brittanybennett.com/

[shaunagm]

Hey @thebbennett, I'm doing a check in of open PRs and noticed a test failure installing pyaml that looks unrelated to your PR. You can see lots of people reporting the issue in this thread: yaml/pyyaml#601

I think you can avoid this by updating your PR branch, because none of the other PRs have this issue. But let me know if htat doesn't work and if this is a blocker for you, and I can look into the problem further.