Add no-export in cbindgen.toml config #924
Conversation
Signed-off-by: tison <[email protected]>
| .export | ||
| .no_export | ||
| .iter() | ||
| .any(|i| i == item.deref().export_name()) |
There was a problem hiding this comment.
I'm not very sure if export_name is desired here but it works for me locally.
| @@ -179,6 +179,15 @@ impl Builder { | |||
| self | |||
| } | |||
|
|
|||
| #[allow(unused)] | |||
There was a problem hiding this comment.
I don't know how it works but follow the "include"/"exclude" pattern above.
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
| * Outer docs should be exported. | ||
| */ | ||
| typedef struct { | ||
| Inner *inner; |
There was a problem hiding this comment.
@emilio weird. When I use the same code for opendal c binding, it generates something like struct Inner *inner for such field. But in cbindgen tests it cannot generate the correct result.
|
It seems that for Style::Tag and Language::C, my work case can pass. But the test coverage also check for other style and language like pyx. The previous @emilio what would you suggest to write a test? I cannot write a proper test for it but it's the same as when we previously merge "no-export` attr. |
For tests, you can include relevant boilerplate using config.header or so to make the test files compile, right? We do that in a bunch of tests. |
@aidanhs @emilio
I need it for my c binding of OpenDAL and local tests pass with this change.
Let me know if this patch needs some improvement :D