Fix types, CSS import in frontend #5257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the same styles, but adds some spaces in the combined CSS. This rule: height:calc(var(--g)*1px) Becomes this rule: height:calc(var(--g) * 1px) That's the same CSS rule, but it does cause a hash change from 58e1c80c0e503be3.css to 1b1c275d4655b992.css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to fix PR #5248, I found several typescript errors, and continued to get style warnings. This PR fixes those errors, most of which are in test code.
next.config.jstonext.config.ts, pass type checkingfxaFlowTracker.test.tsto use a number for the time parameter instead of a string, matching the codeimport "react-toastify/dist/ReactToastify.css", to avoid dart sass warnings. This has the same declarations but with some additional space, which caused the CSS hash to change.How to test:
cd frontendnpx tsc --noEmitruns with no warnings or errorsnpm run testruns with all tests passing