Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual npm updates - npm dedupe, remove typescript pin, update nanoid #5271

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jwhitlock
Copy link
Member

This applies some manual npm updates:

  • npm dedupe - This did not remove any duplicate packages, but did update @typescript-eslint/* from 8.15.0 to 8.18.1.
  • Remove typescript pin - The new @typescript-eslint/* packages specify the supported typescript release ranges. The old range was >=4.7.4 <5.5.0, the new range is >=4.8.4 <5.8.0. Hopefully dependabot will detect it can upgrade typescript.
  • Update nanoid from 3.3.7 to 3.3.8. This fixes a security issue if used in a browser context. We're using it on the server, where it would cause build failures, and do not see the issue as described in the report. It is not urgent to get this to production.

It seems to be a good idea to run this periodically.
The latest `npm dedupe` upgraded @typescript-eslint/* from 8.15.0 to
8.18.1. This new version changed typescript from an optional peer
dependency to a peer dependency with range ">=4.8.4 <5.8.0". We should
get the proper typescript version on the next dependabot run, and no
further warnings about using a version that is not officially supported.
This resolves a security issue in a browser context. We're running it on
the server in the build process, and aren't seeing the reported issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant