Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfi-v2-trading): dynamic share images #1006

Merged
merged 17 commits into from
Dec 19, 2024

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Dec 18, 2024

Adds dynamic share images for active positions, closed positions, and pool trading pages themselves. Also improves portfolio card data viz.

  • Portfolio Card PnL / position data
  • Portfolio tooltip upgrades
  • Share position dialog
    • Copy generated share image to clipboard
    • Download generated share image
    • Open native share drawer on mobile
  • Close position confirmation / success screens

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-v2-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:05pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
marginfi-landing-page ⬜️ Skipped (Inspect) Dec 19, 2024 2:05pm
marginfi-v2-docs ⬜️ Skipped (Inspect) Dec 19, 2024 2:05pm
marginfi-v2-ui ⬜️ Skipped (Inspect) Dec 19, 2024 2:05pm

@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 18, 2024 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 18, 2024 17:39 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 18, 2024 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 18, 2024 17:49 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui December 18, 2024 17:49 Inactive
Copy link

alwaysmeticulous bot commented Dec 18, 2024

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit a41c7f8. This comment will update as new commits are pushed.

@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 19, 2024 02:14 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 19, 2024 02:14 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui December 19, 2024 02:14 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 19, 2024 04:00 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 19, 2024 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 19, 2024 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui December 19, 2024 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 19, 2024 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui December 19, 2024 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 19, 2024 13:50 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-landing-page December 19, 2024 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-ui December 19, 2024 14:00 Inactive
@vercel vercel bot temporarily deployed to Preview – marginfi-v2-docs December 19, 2024 14:00 Inactive
@chambaz chambaz marked this pull request as ready for review December 19, 2024 14:02
@chambaz chambaz requested a review from losman0s as a code owner December 19, 2024 14:02
@chambaz chambaz merged commit 28801d5 into develop Dec 19, 2024
6 checks passed
@chambaz chambaz deleted the feature/dynamic-share-images branch December 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant