Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Ci pipeline #174

Merged
merged 19 commits into from
Nov 8, 2024
Merged

Release Ci pipeline #174

merged 19 commits into from
Nov 8, 2024

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Nov 4, 2024

No description provided.

@zeotuan zeotuan marked this pull request as draft November 4, 2024 10:35
.github/workflows/release.yml Show resolved Hide resolved
build.sbt Outdated
import xerial.sbt.Sonatype.sonatypeCentralHost
ThisBuild / sonatypeCredentialHost := sonatypeCentralHost
Copy link
Collaborator Author

@zeotuan zeotuan Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SemyonSinchenko @alfonsorr @MrPowers Either this if we have sonatypeCentral account or
For newer sonatypeAccount

ThisBuild / sonatypeCredentialHost := "s01.oss.sonatype.org"
sonatypeRepository := "https://s01.oss.sonatype.org/service/local"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @MrPowers didn't create a new account, you don't need to configure the host with sbt-ci-release because he has an account in the old server and we have to publish there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfonsorr sure let's me remove this part. I probably going to just keep the generic part and leave the specific setup to whoever have control to these settings

@zeotuan zeotuan marked this pull request as ready for review November 8, 2024 08:23
@zeotuan zeotuan requested a review from alfonsorr November 8, 2024 08:23
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks good. Thanks @zeotuan
P.S. Can we have a similar one for tsumugi?

Comment on lines 15 to 18
PGP_PASSPHRASE: ${{secrets.PGP_PASSPHRASE}}
PGP_SECRET: ${{secrets.PGP_SECRET}}
SONATYPE_PASSWORD: ${{secrets.SONATYPE_PASSWORD}}
SONATYPE_USERNAME: ${{secrets.SONATYPE_USERNAME}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PGP_PASSPHRASE: ${{secrets.PGP_PASSPHRASE}}
PGP_SECRET: ${{secrets.PGP_SECRET}}
SONATYPE_PASSWORD: ${{secrets.SONATYPE_PASSWORD}}
SONATYPE_USERNAME: ${{secrets.SONATYPE_USERNAME}}
PGP_PASSPHRASE: ${{secrets.PGP_PASSPHRASE}}
PGP_SECRET: ${{secrets.PGP_LONG_ID}}
SONATYPE_PASSWORD: ${{secrets.MAVEN_PASSWORD}}
SONATYPE_USERNAME: ${{secrets.MAVEN_USERNAME}}

As @MrPowers provided in Slack

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
fyi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@zeotuan
Copy link
Collaborator Author

zeotuan commented Nov 8, 2024

To me it looks good. Thanks @zeotuan P.S. Can we have a similar one for tsumugi?

Yeah let's me prepare PR

@zeotuan zeotuan requested a review from alfonsorr November 8, 2024 10:34
@alfonsorr
Copy link
Collaborator

Lest see if we can release a snapshot version with this pr

@zeotuan zeotuan merged commit 0d5789e into mrpowers-io:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants