Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI only to check PR. Release of snapshots. #175

Merged

Conversation

alfonsorr
Copy link
Collaborator

No description provided.

@alfonsorr alfonsorr requested review from zeotuan and SemyonSinchenko and removed request for SemyonSinchenko November 8, 2024 11:16
Copy link
Collaborator

@zeotuan zeotuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is going to works. I always thought it has to be git tag:
git tag -a v0.1.0 -m "v0.1.0"
But let's try it

@@ -1,8 +1,5 @@
name: CI
on:
push:
branches:
- main
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a workflow_dispatch too? To be able to run tests/ci for main if needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can check it in the release previously to release the jar

@alfonsorr alfonsorr merged commit 990115f into mrpowers-io:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants