Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tree-string color diff #176

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Add tree-string color diff #176

merged 5 commits into from
Nov 20, 2024

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Nov 11, 2024 •
edited
Loading

Add support for display Tree String color diff for schema:
Currently available with assertSchemaDiff with SchemaDiffOutputFormat.Tree
image

@zeotuan zeotuan mentioned this pull request Nov 11, 2024
Closed
3 tasks
@zeotuan zeotuan marked this pull request as ready for review November 17, 2024 01:45
@zeotuan zeotuan requested a review from alfonsorr November 17, 2024 01:45
SemyonSinchenko
SemyonSinchenko approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One minor question: what do you think about moving numbers (6, 21, etc.) to object fields (uppercase constants)?

@zeotuan zeotuan merged commit cffd91a into mrpowers-io:main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

@alfonsorr alfonsorr alfonsorr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeotuan @alfonsorr @SemyonSinchenko