Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal contributing guide #42
Minimal contributing guide #42
Changes from 1 commit
b93f178
f43c835
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make run_spark_server
results in a build error -[ERROR] /workspaces/tsumugi-spark/tsumugi-server/src/test/scala/com/ssinchenko/tsumugi/DeequUtilsTest.scala:66: type mismatch; found : scala.util.Try[com.amazon.deequ.VerificationRunBuilder] required: com.amazon.deequ.VerificationRunBuilder [ERROR] one error found
Changing the statement
val deequSuite = DeequSuiteBuilder.protoToVerificationSuite(data, protoSuiteBuilder.build())
toval deequSuite = DeequSuiteBuilder.protoToVerificationSuite(data, protoSuiteBuilder.build()).getOrElse(throw new RuntimeException("Failed to create VerificationSuite"))
in/workspaces/tsumugi-spark/tsumugi-server/src/test/scala/com/ssinchenko/tsumugi/DeequUtilsTest.scala
and adding relevant imports resolved it, however my Scala is no good. Please have a look and use your judgement!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I just realized that I somehow missed this in previous PR and we actually do not have automated testing for scala server. Will create a separate Issue to tackle this. Since it's not really related to this PR I will merge it in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to fix the problem in this PR but we also need to run some minimal python client tests in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SemyonSinchenko Sorry Did not get updated on this. I figured we already have #40 which might be a good candidate for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR but On line 12 there is a typo
Lungauge
can we include it in this PR